[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-03-01 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1122537430 ## apisix/core/request.lua: ## @@ -131,26 +135,37 @@ function _M.set_header(ctx, header_name, header_value) changed = a6_request.is_request_header_set()

[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-26 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1118203356 ## apisix/core/request.lua: ## @@ -131,26 +129,41 @@ function _M.set_header(ctx, header_name, header_value) changed = a6_request.is_request_header_set()

[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-20 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1112457447 ## apisix/core/request.lua: ## @@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value) end end -function _M.add_header(header_name, head

[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-20 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1112451480 ## apisix/core/request.lua: ## @@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value) end end -function _M.add_header(header_name, head

[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-20 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1112451480 ## apisix/core/request.lua: ## @@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value) end end -function _M.add_header(header_name, head