spacewander commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-757116854
@HelloBug0
> > However, as we only get cached data from lrucache, which is process
level cache, so it is safe to remove the second try. PR is welcome!
> OK, I will check
spacewander commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-757116854
@HelloBug0
> > However, as we only get cached data from lrucache, which is process
level cache, so it is safe to remove the second try. PR is welcome!
> OK, I will check
spacewander commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-755022304
Ping @HelloBug0?
This is an automated message from the Apache Git Service.
To respond to the message, please log o
spacewander commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751417757
The second `fetch_valid_cache` is a cache with lock pattern. You can take a
look at:
https://github.com/thibaultcha/lua-resty-mlcache/blob/acf6d6e9d83d983425e0735b696a721851336
spacewander commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751309188
There is only a getter, and a setter to set a stale object back as valid
object. There is not a way to create a new one.
-
spacewander commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751181222
We only need lock when the cache is miss, and need to create the object (via
query other system)
This is an autom
spacewander commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751154050
>
>
> I really appreciate your explanation. Merry Christmas 🍬
>
> But why don't we use lock before line 100 if it's serial created ?
I am confused. From 85 to
spacewander commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-750816939
1, 2: the `item_release` is a callback to be called when cached value is
released. It isn't used now.
3: the lock is bypassed in most of the cases except `serial_creating` is
s
