[GitHub] [apisix] spacewander commented on issue #3392: bug: timeout in upstream_schema can be set to zero, but in fact not workable.

2021-01-21 Thread GitBox
spacewander commented on issue #3392: URL: https://github.com/apache/apisix/issues/3392#issuecomment-765062764 We need to change `minimum` to `exclusiveMinimum`. Would you contribute a PR? Remember to add a test for it. This

[GitHub] [apisix] spacewander commented on issue #3392: bug: timeout in upstream_schema can be set to zero, but in fact not workable.

2021-01-21 Thread GitBox
spacewander commented on issue #3392: URL: https://github.com/apache/apisix/issues/3392#issuecomment-765094525 You can add a case in t/admin/upstream2.t like this one: https://github.com/apache/apisix/blob/d698220341776791f6e34568e0a17d52ab517919/t/admin/upstream.t#L323 ---

[GitHub] [apisix] spacewander commented on issue #3392: bug: timeout in upstream_schema can be set to zero, but in fact not workable.

2021-01-21 Thread GitBox
spacewander commented on issue #3392: URL: https://github.com/apache/apisix/issues/3392#issuecomment-765094878 You can submit a draft PR and make it pass later. This is an automated message from the Apache Git Service. To res

[GitHub] [apisix] spacewander commented on issue #3392: bug: timeout in upstream_schema can be set to zero, but in fact not workable.

2021-01-21 Thread GitBox
spacewander commented on issue #3392: URL: https://github.com/apache/apisix/issues/3392#issuecomment-765062764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us