[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout

2021-12-07 Thread GitBox
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-988544339 @dmsolr Maybe we can create a new release of skywalking-nginx-lua now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout

2021-05-25 Thread GitBox
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847909777 > In addition, sw_tracer:finish should be called in header_filter_by_lua phase logically, because header_filter_by_lua phase is before body_filter_by_lua phase. Calling

[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout

2021-05-25 Thread GitBox
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847574701 My opinion: 1. normal response: keep the current behavior 2. without response (the timed out case pointed by @yxudong): add `finish` call if we haven't called it yet 3.

[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout

2021-05-24 Thread GitBox
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847493355 Response without body also causes this problem, like HEAD request's response. -- This is an automated message from the Apache Git Service. To respond to the message, please log