[GitHub] [apisix] tzssangglass commented on pull request #2943: feat: support enable/disable route

2020-12-08 Thread GitBox
tzssangglass commented on pull request #2943: URL: https://github.com/apache/apisix/pull/2943#issuecomment-741489372 thanks to the people at code review, and thanks for the guidance! This is an automated message from the Apac

[GitHub] [apisix] tzssangglass commented on pull request #2943: feat: support enable/disable route

2020-12-04 Thread GitBox
tzssangglass commented on pull request #2943: URL: https://github.com/apache/apisix/pull/2943#issuecomment-739117237 > is it necessary to add a caseļ¼š > create a route disabled -> hit route failed-> enable it -> hit route successfully? test case 1 ~ 4 is testing for uri match, the

[GitHub] [apisix] tzssangglass commented on pull request #2943: feat: support enable/disable route

2020-12-03 Thread GitBox
tzssangglass commented on pull request #2943: URL: https://github.com/apache/apisix/pull/2943#issuecomment-738170623 describe a strange phenomenon, I was using `/route_status` api and create new routes because I found that using route id 1 and `/hello` always failed when I ran my local tes

[GitHub] [apisix] tzssangglass commented on pull request #2943: feat: support enable/disable route

2020-12-03 Thread GitBox
tzssangglass commented on pull request #2943: URL: https://github.com/apache/apisix/pull/2943#issuecomment-738154214 solve above This is an automated message from the Apache Git Service. To respond to the message, please log