[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-08-04 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1206032661 @nic-chen "grpc-status" and "grpc-message" are not in the chunk, they are in the response header, so no need to set `ngx.header["Trailer"] = {"grpc-status", "grpc-message"}` --

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-08-03 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1204824000 @nic-chen why do we set `Trailer` response header here? https://github.com/apache/apisix/blob/master/apisix/plugins/grpc-transcode.lua#L155 the `Trailer` response header is us

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-30 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1200112354 @spacewander i have found the problem today, Forgetting that a proxy has been configured ``` curl -v -sS -H 'Host: Test-Nginx' 'http://127.0.0.1:1984/ver' * Uses proxy en

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-27 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1196587118 @spacewander Have you ever encountered this problem? I reinstalled my system and failed on test cases. ``` prove -Itest-nginx/lib -I./ -r t/plugin/grpc-transcode.t t/plu

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-19 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1189310998 `show_status_in_body`, optional, when enabled, will show decoded `grpc-status-details-bin` in response body `status_detail_type`, optional, the message type of the `grpc-status

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-18 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1187715374 ``` local encoded_data = "CA4SDk91dCBvZiBzZXJ2aWNlGlcKKnR5cGUuZ29vZ2xlYXBpcy5jb20vaGVsbG93b3JsZC5FcnJvckRldGFpbBIpCAESHFRoZSBzZXJ2ZXIgaXMgb3V0IG9mIHNlcnZpY2UaB3NlcnZpY2U

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-17 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1186514351 ``` message ErrorDetail { int64 code = 1; string message = 2; string type = 3; } local data = pb.decode("ErrorDetail", data) ``` message type

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-15 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1185364801 > ``` local encoded_data = "CA4SDk91dCBvZiBzZXJ2aWNlGlcKKnR5cGUuZ29vZ2xlYXBpcy5jb20vaGVsbG93b3JsZC5FcnJvckRldGFpbBIpCAESHFRoZSBzZXJ2ZXIgaXMgb3V0IG9mIHNlcnZpY2UaB3Nlcn

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-14 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1185084735 @tokers @tzssangglass do you agree with this plan ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-14 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1184590468 I'm going to add 2 configuration items 1. `cpy_details_to_body`: if true, copy `grpc-status-details-bin` to response body, the one in response header won't be deleted {

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-11 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1180516199 `grpc-status-details-bin` is encoded with marshalling followed by base64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-11 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1180503208 @tokers do we have an example about how to decode `grpc-status-details-bin` via proto? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-10 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1179747947 Do we need to decode `grpc-status-details-bin` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-08 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1179144382 let me handle this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm