[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-25 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1483767423 /merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-24 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1483648806 @Baoyuantop could you merge this PR, I have no permission to merge🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-23 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1482102227 @guoqqqi @LiteSun @SkyeYoung take a look at this PR, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-22 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1480496510 @Baoyuantop take a look at this PR, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-22 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1479768889 @Baoyuantop Fixed the CI error, please return CI, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-19 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1475647916 @Baoyuantop Could you return the CI to re-run the workflows -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-19 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1475630617 Return CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-19 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1475183254 @Baoyuantop Please return CI, I add `consul` check, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-10 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1464723432 @Baoyuantop please talk a look at this PR, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-06 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1455933742 @Baoyuantop the e2e test is not stable, i did not changed any code in `data-loader-import.cy.js`; please return ci again, thanks -- This is an automated message from the Apa

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-03 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1454332322 > > > Codes LGTM, we need to add an E2E test for it. You can refer to https://github.com/apache/apisix-dashboard/blob/master/web/cypress/e2e/route/create-route-with-service-dis

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-03-02 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1452786964 > Codes LGTM, we need to add an E2E test for it. You can refer to https://github.com/apache/apisix-dashboard/blob/master/web/cypress/e2e/route/create-route-with-service-discove

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-02-27 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1447491944 @bzp2010 @Baoyuantop Could you have a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-02-20 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1436988327 @bzp2010 Cloud you have a look ath this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-02-08 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1422658524 return ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-02-07 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1421908384 @guoqqqi @bzp2010 could you have a look at this PR, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and