[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-20 Thread GitBox
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764447946 > it would be better to add three more test cases: > > * export a route created with upstream id > * export a route created with service which is created

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765076940 > > > Hi, @Jaycean. Need unit test. > > > > > > At present, the function interface needs to export the existing route data and ensure the correctness o

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764447946 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-24 Thread GitBox
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766539166 @liuxiran @nic-chen The unit test and test cases have been supplemented. In the process of testing, I found a problem: - At present, the path data structure

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-24 Thread GitBox
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766539166 @liuxiran @nic-chen The unit test and test cases have been supplemented. In the process of testing, I found a problem: - At present, the path data structure

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-24 Thread GitBox
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766610459 In my opinion, from the perspective of apimix platform, I choose scheme a to satisfy the users of apimix platform A. The function that URI can be renamed is more