[GitHub] [apisix-dashboard] bzp2010 commented on pull request #330: feat(authentication): create authentication module

2020-08-21 Thread GitBox
bzp2010 commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-678207653 The listed problems have been fixed. This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #330: feat(authentication): create authentication module

2020-08-16 Thread GitBox
bzp2010 commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-674489433 So far, I think the basic functionality has been completed, requiring code review and more testing to check for logical or coding errors. ### some inspection items

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #330: feat(authentication): create authentication module

2020-08-10 Thread GitBox
bzp2010 commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-671318866 The changes to the Manager API are basically complete, after which a frontend and backend connecting will be attempted. -

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #330: feat(authentication): create authentication module

2020-08-05 Thread GitBox
bzp2010 commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-669646396 > Oh when visiting the demo site for the first time, because there has no API address in the local storage, so we MUST submit the form in `/settings` page, then it will w

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #330: feat(authentication): create authentication module

2020-08-02 Thread GitBox
bzp2010 commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-667679866 > I noticed that `user/login` will redirect to `settings` here[1], not sure if it's ok here. > > [1] https://deploy-preview-330--apisix-dashboard.netlify.app/settin

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #330: feat(authentication): create authentication module

2020-08-02 Thread GitBox
bzp2010 commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-667676253 > 1. `user/login` seems not working :DD > 2. The title for `Settings` is broken :DD I tried to pull the latest master branch code. I didn't find these cases when