[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-22 Thread GitBox
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803907452 As the function is in a public component, it can be tested once and there is no need to add tests for other pages. Thanks. -- This is an automated message from the Ap

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-22 Thread GitBox
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803887517 Hi, @stu01509 Again these pages need to be tested. ![image](https://user-images.githubusercontent.com/72343596/111964614-c2089c00-8b2f-11eb-8ab0-10e8e043d40a.png)

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-21 Thread GitBox
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803524401 The CI error is because the plugin has not been removed. Please refer to: `web/cypress/integration/plugin/create-edit-delete-plugin.spec.js` ![image](https://user-

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803246224 CI error: https://github.com/apache/apisix-dashboard/pull/1597/checks?check_run_id=2148899222 This CI error has been fixed in #1584. -- This is an automated messag

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802855150 Hi,you can find it in the Create, Configure Plugin step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-16 Thread GitBox
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-800070434 Hi, We need to test the functionality not only on the plug-in page but also on the route page and the service page to make sure it works. -