[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #884: test: add route with valid remote_address (E2E)

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r532056811 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -24,7 +24,7 @@ import ( func TestRoute_with_vaild_remote_addr(t *testing.T) {

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #884: test: add route with valid remote_address (E2E)

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r532056800 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #884: test: add route with valid remote_address (E2E)

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r532056762 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #884: test: add route with valid remote_address (E2E)

2020-11-27 Thread GitBox
idbeta commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531446884 ## File path: api/test/e2e/route_with_valid_remote_addr_test.go ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under