[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #979: Refactor online debug be

2020-12-17 Thread GitBox
imjoey commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r545622926 ## File path: api/internal/handler/route/route.go ## @@ -397,3 +412,75 @@ func Exist(c *gin.Context) (interface{}, error) { return nil,

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #979: Refactor online debug be

2020-12-17 Thread GitBox
imjoey commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r545622926 ## File path: api/internal/handler/route/route.go ## @@ -397,3 +412,75 @@ func Exist(c *gin.Context) (interface{}, error) { return nil,

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #979: Refactor online debug be

2020-12-15 Thread GitBox
imjoey commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r543860366 ## File path: api/test/e2e/route_online_debug_test.go ## @@ -42,7 +42,7 @@ func TestRoute_Online_Debug_Route_Not_Exist(t *testing.T) {