[GitHub] [apisix-dashboard] imjoey commented on issue #1262: release workflow

2021-01-17 Thread GitBox
imjoey commented on issue #1262: URL: https://github.com/apache/apisix-dashboard/issues/1262#issuecomment-761767684 @juzhiyuan Since https://github.com/apache/apisix-website/pull/143 has been merged, could this be closed now? We can reopen it if anything in the docs needs improvement.

[GitHub] [apisix-dashboard] imjoey commented on issue #1262: release workflow

2021-01-11 Thread GitBox
imjoey commented on issue #1262: URL: https://github.com/apache/apisix-dashboard/issues/1262#issuecomment-757965787 @juzhiyuan Regarding to tag `v2.3`, I'm still curious about shall we need to revert `branch v2.3` and `tag v2.3` to commit

[GitHub] [apisix-dashboard] imjoey commented on issue #1262: release workflow

2021-01-11 Thread GitBox
imjoey commented on issue #1262: URL: https://github.com/apache/apisix-dashboard/issues/1262#issuecomment-757813163 > @imjoey Here are 2 repos that could cover this requirement: > > * https://github.com/apache/apisix-website > * https://github.com/apache/apisix-dashboard >

[GitHub] [apisix-dashboard] imjoey commented on issue #1262: release workflow

2021-01-11 Thread GitBox
imjoey commented on issue #1262: URL: https://github.com/apache/apisix-dashboard/issues/1262#issuecomment-757812325 > LGTM too. > > It looks similar to what was discussed before. Are there something that need special attention? Thanks. Hi @nic-chen , IMHO, we should pay more

[GitHub] [apisix-dashboard] imjoey commented on issue #1262: release workflow

2021-01-11 Thread GitBox
imjoey commented on issue #1262: URL: https://github.com/apache/apisix-dashboard/issues/1262#issuecomment-757754368 > Fine, @imjoey could you please add this workflow to some documentation, like contributing or release-guide? @juzhiyuan very glad to add relevant docs. May I ask

[GitHub] [apisix-dashboard] imjoey commented on issue #1262: release workflow

2021-01-11 Thread GitBox
imjoey commented on issue #1262: URL: https://github.com/apache/apisix-dashboard/issues/1262#issuecomment-757693860 > @juzhiyuan @nic-chen @liuxiran > > The recommended mode from me for this project, is to adapt the **Gitlab flow**, especially the **Release branches with GitLab

[GitHub] [apisix-dashboard] imjoey commented on issue #1262: release workflow

2021-01-10 Thread GitBox
imjoey commented on issue #1262: URL: https://github.com/apache/apisix-dashboard/issues/1262#issuecomment-757681888 @juzhiyuan @nic-chen @liuxiran The recommended mode from me for this project from me, is to adept the **Gitlab flow**, especially the **Release branches with GitLab