imjoey commented on pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#issuecomment-752948167
> It seems that only push can retigger ci, try to push -f?
@liuxiran thanks for reply. It seems that I've no additional changes to
push. So let me wait for the
imjoey commented on pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#issuecomment-752921570
@membphis @nic-chen @juzhiyuan this pr is ready for reviewing, looking
forward to your further suggestions. BTW, CI seems a little wired. Could I do
anything to
imjoey commented on pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#issuecomment-752901239
@juzhiyuan Hi, I notice that you moved the target branch to `v2.3` from
`master` branch for this PR. Actually, this PR can only apply to `master`
branch, since the
imjoey commented on pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#issuecomment-752891738
> missing test case to confirm the file `.githash` contains the correct
content
@membphis thanks for your advice. PR updated and added the content
verification
imjoey commented on pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#issuecomment-752811229
> @imjoey
>
> It would be great to add a test case for the modified code, please refer
to:
>
imjoey commented on pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#issuecomment-752477813
@juzhiyuan @starsz I've no idea why the CI test *Semantic Pull Request*
fails. Much appreciated if you can help me out. Thanks.
