[GitHub] [apisix-dashboard] imjoey commented on pull request #1220: feat: add plugin icon

2021-01-06 Thread GitBox
imjoey commented on pull request #1220: URL: https://github.com/apache/apisix-dashboard/pull/1220#issuecomment-755904632 @juzhiyuan OK, I could do the cherry pick for this for release v2.3. This is an automated message from

[GitHub] [apisix-dashboard] imjoey commented on pull request #1220: feat: add plugin icon

2021-01-06 Thread GitBox
imjoey commented on pull request #1220: URL: https://github.com/apache/apisix-dashboard/pull/1220#issuecomment-755902054 @juzhiyuan Hi, the issue https://github.com/apache/apisix-dashboard/issues/1168 was marked as included in milestone 2.3. Please check that whether this PR requires cherr

[GitHub] [apisix-dashboard] imjoey commented on pull request #1220: feat: add plugin icon

2021-01-06 Thread GitBox
imjoey commented on pull request #1220: URL: https://github.com/apache/apisix-dashboard/pull/1220#issuecomment-755832835 @nic-chen @juzhiyuan that's right. Let us mainly focus on the functionality for now. Design is a long-term work. 😄

[GitHub] [apisix-dashboard] imjoey commented on pull request #1220: feat: add plugin icon

2021-01-06 Thread GitBox
imjoey commented on pull request #1220: URL: https://github.com/apache/apisix-dashboard/pull/1220#issuecomment-755782419 > The logic is updated in this [commit](https://github.com/apache/apisix-dashboard/pull/1220/commits/e04fb7f7660bc336930eecfd0aa7d2bec78c25c5). Hope this helps you. 😄