[GitHub] [apisix-dashboard] jinchizhou commented on pull request #1067: fix: error check to ensure path id doesn't conflict body id

jinchizhou commented on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-749690818 I am only converting to a string if the type is float. The body id are guarantee to be a string or a float I assume? I use a new variable so that shouldn't be

[GitHub] [apisix-dashboard] jinchizhou commented on pull request #1067: fix: error check to ensure path id doesn't conflict body id

jinchizhou commented on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-749265810 Not sure why these CI tests are blocking. I verified that these tests are failing locally even without my changes.

[GitHub] [apisix-dashboard] jinchizhou commented on pull request #1067: fix: error check to ensure path id doesn't conflict body id

jinchizhou commented on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748554989 FYI, I'm unable to request reviews This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] jinchizhou commented on pull request #1067: fix: error check to ensure path id doesn't conflict body id

jinchizhou commented on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748542416 @nic-chen could you please take a look thanks! This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] jinchizhou commented on pull request #1067: [fix] error check to ensure path id doesn't conflict body id

jinchizhou commented on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-747908918 Nope, I'll add some tests. This is an automated message from the Apache Git Service. To respond to