[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #551: feature: sync json schema from APISIX and check schema when create or update resource

2020-10-12 Thread GitBox
juzhiyuan commented on a change in pull request #551: URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503654569 ## File path: api/internal/handler/ssl/ssl_test.go ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #551: feature: sync json schema from APISIX and check schema when create or update resource

2020-10-12 Thread GitBox
juzhiyuan commented on a change in pull request #551: URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503648630 ## File path: api/internal/handler/ssl/ssl_test.go ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #551: feature: sync json schema from APISIX and check schema when create or update resource

2020-10-12 Thread GitBox
juzhiyuan commented on a change in pull request #551: URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503648630 ## File path: api/internal/handler/ssl/ssl_test.go ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #551: feature: sync json schema from APISIX and check schema when create or update resource

2020-10-12 Thread GitBox
juzhiyuan commented on a change in pull request #551: URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503646130 ## File path: api/internal/handler/ssl/ssl_test.go ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #551: feature: sync json schema from APISIX and check schema when create or update resource

2020-10-11 Thread GitBox
juzhiyuan commented on a change in pull request #551: URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503025206 ## File path: api/build-tools/json.lua ## @@ -0,0 +1,400 @@ +-- Review comment: Not sure if this file has the license issue, cc @moonming