[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-11 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 ping @membphis @liuxiran This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-11 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691042697 ![image](https://user-images.githubusercontent.com/2106987/92921226-40d89a00-f466-11ea-92b9-350198d9256a.png) -

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-11 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691341782 Good catch, @membphis, could you please describe this logic? This is an automated message from the Apache

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-11 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691363046 Even though we could use Passive Check only, but because once the upstream is down, the Gateway doesn't know when to recover just like Active Check does. -

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-13 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691772846 It's not a hurry :D because we could use Active Health Check and Passive Health Check independent, but we recommend enabling active health check when enabling passive healt

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-14 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-692505266 hi @liuxiran, would you like to implement this feature (if you have free time)? This is an automated messa

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-19 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695364533 > `active.type` is mentioned in the test case [=== TEST 6: invalid route: wrong active.type](https://github.com/apache/apisix/blob/8493a607ce869ab335eac1d0e799ffecff10fb93/

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-20 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695872120 @liuxiran I just had a quick discussion with @membphis, he will help you to make sure if the `type` filed is needed :D

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-21 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695872120 @liuxiran I just had a quick discussion with @membphis, he will help you to make sure if the `type` filed is needed :D