[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #330: feat(authentication): create authentication module

2020-08-19 Thread GitBox
juzhiyuan commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-675990952 Any updates here? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #330: feat(authentication): create authentication module

2020-08-15 Thread GitBox
juzhiyuan commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-674402387 Could we convert this to Draft(I see there has a convert to draft tip on the top right panel)? And you can make it ready anytime when it’s ready :D ---

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #330: feat(authentication): create authentication module

2020-08-10 Thread GitBox
juzhiyuan commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-671371959 > The changes to the Manager API are basically complete, after which a frontend and backend connecting will be attempted. @gxthrj Please take a look, thanks! --

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #330: feat(authentication): create authentication module

2020-08-05 Thread GitBox
juzhiyuan commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-669645414 Oh when visiting the demo site for the first time, because there has no API address in the local storage, so we MUST submit the form in `/settings` page, then it will w

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #330: feat(authentication): create authentication module

2020-08-05 Thread GitBox
juzhiyuan commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-669640646 > > I noticed that `user/login` will redirect to `settings` here[1], not sure if it's ok here. > > [1] https://deploy-preview-330--apisix-dashboard.netlify.app/settin

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #330: feat(authentication): create authentication module

2020-08-02 Thread GitBox
juzhiyuan commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-667679201 Oh! I noticed we may DO NOT need to import every i18n file under `pages/locale`, umi.js will import them automatically, you could have a try.

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #330: feat(authentication): create authentication module

2020-08-02 Thread GitBox
juzhiyuan commented on pull request #330: URL: https://github.com/apache/apisix-dashboard/pull/330#issuecomment-667637695 1. `user/login` seems not working :DD 2. The title for `Settings` is broken :DD This is an automate