[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1812: fix: can not configure upstream with no nodes

2021-04-26 Thread GitBox
liuxiran commented on a change in pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#discussion_r619734507 ## File path: api/internal/core/entity/format_test.go ## @@ -101,3 +101,53 @@ func TestNodesFormat_Map(t *testing.T) { assert.Contains(t

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1812: fix: can not configure upstream with no nodes

2021-04-24 Thread GitBox
liuxiran commented on a change in pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#discussion_r619734507 ## File path: api/internal/core/entity/format_test.go ## @@ -101,3 +101,53 @@ func TestNodesFormat_Map(t *testing.T) { assert.Contains(t