[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-27 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-768166641 Thanks for @nic-chen and all reviewers, pr megerd This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-27 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-768155965 ping @starsz @imjoey @Jaycean for review, thanks This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-22 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-765343958 Do we need to add a test case about a route with as many props as possible? This is an automated

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764442783 Do we need to add **test cases** about 1. import a error file 2. a file includes two or more APIs

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-20 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764442783 Do we need to add **test cases** about 1. import a error file 2. a file includes two or more APIs

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-12 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-759148972 https://github.com/apache/apisix-dashboard/pull/1102/checks?check_run_id=1686825100 another unstable fe e2e test case, cc @LiteSun

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-12 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-759148662 > > before we import new route data, do we need to clean the old route first? > > I think that the original data should not be modified, and the status of the

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-11 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-758287503 > before we import new route data, do we need to clean the old route first? how about giving the choice to users? e.g: Add a param to deside whether to cover