[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1057: feat: support global rules for Manager API

2020-12-22 Thread GitBox
membphis commented on a change in pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#discussion_r547771052 ## File path: api/internal/handler/global_rule/global_rule.go ## @@ -50,7 +49,7 @@ func (h *Handler) ApplyRoute(r *gin.Engine) {

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1057: feat: support global rules for Manager API

2020-12-22 Thread GitBox
membphis commented on a change in pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#discussion_r547170376 ## File path: api/internal/handler/global_rule/global_rule.go ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1057: feat: support global rules for Manager API

2020-12-17 Thread GitBox
membphis commented on a change in pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#discussion_r545597525 ## File path: api/internal/handler/global_rule/global_rule.go ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1057: feat: support global rules for Manager API

2020-12-17 Thread GitBox
membphis commented on a change in pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#discussion_r545110538 ## File path: api/internal/handler/global_rule/global_rule.go ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF)