[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with vaild remote_address (E2E)

2020-11-26 Thread GitBox
membphis commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531083296 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -24,7 +24,7 @@ import ( func TestRoute_with_vaild_remote_addr(t *testing.T) {

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with vaild remote_address (E2E)

2020-11-26 Thread GitBox
membphis commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531083023 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -24,7 +24,7 @@ import ( func TestRoute_with_vaild_remote_addr(t *testing.T) {

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with vaild remote_address (E2E)

2020-11-26 Thread GitBox
membphis commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531071867 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one