[GitHub] [apisix-dashboard] membphis commented on pull request #902: fix: make field ID compatible with both string and int

2020-11-28 Thread GitBox
membphis commented on pull request #902: URL: https://github.com/apache/apisix-dashboard/pull/902#issuecomment-735351866 > `api/test/e2e/id_compatible_test.go` looks good for me for the source code, need @gxthrj @ShiningRush @tokers @spacewander help ^_^

[GitHub] [apisix-dashboard] membphis commented on pull request #902: fix: make field ID compatible with both string and int

2020-11-28 Thread GitBox
membphis commented on pull request #902: URL: https://github.com/apache/apisix-dashboard/pull/902#issuecomment-735349358 `api/test/e2e/id_compatible_test.go` looks good for me. I think we can turn this PR to `ready` @nic-chen --