[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-22 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-765366914 > Do we need to add a test case about a route with as many props as possible sure This is an

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764209076 > @nic-chen Hi, the CI of your PR has not been passed. You need to rebase the master branch, and the get list method of store needs to add the `context` parameter

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-20 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764209076 > @nic-chen Hi, the CI of your PR has not been passed. You need to rebase the master branch, and the get list method of store needs to add the `context` parameter

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-18 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-762577575 > > > Hi, the two functions of import and export are closely related, so I want to discuss the name of the folder with you. I personally think that the two files are

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-15 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-760890023 > Hi, the two functions of import and export are closely related, so I want to discuss the name of the folder with you. I personally think that the two files are

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-12 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-759184568 > > > before we import new route data, do we need to clean the old route first? > > > > > > I think that the original data should not be modified, and the

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-12 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-759145529 > before we import new route data, do we need to clean the old route first? I think that the original data should not be modified, and the status of the