[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557915888 ## File path: api/internal/filter/authentication.go ## @@ -17,62 +17,79 @@ package filter import ( + "errors" "net/http"

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557900139 ## File path: api/internal/filter/authentication.go ## @@ -17,62 +17,79 @@ package filter import ( + "errors" "net/http"

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557900139 ## File path: api/internal/filter/authentication.go ## @@ -17,62 +17,79 @@ package filter import ( + "errors" "net/http"

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557853660 ## File path: api/cmd/managerapi.go ## @@ -19,6 +19,7 @@ package cmd import ( "context" "fmt" +

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557852288 ## File path: api/go.mod ## @@ -21,6 +21,7 @@ require ( github.com/gin-contrib/sessions v0.0.3 github.com/gin-contrib/static

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557852183 ## File path: api/cmd/managerapi.go ## @@ -62,7 +63,7 @@ func NewManagerAPICommand() *cobra.Command { var newMws