[GitHub] [apisix-dashboard] starsz commented on issue #758: [DISCUSS] Create a new file to generalize error response

2021-01-21 Thread GitBox
starsz commented on issue #758: URL: https://github.com/apache/apisix-dashboard/issues/758#issuecomment-764434972 This will be discussed in M2.4 and finished in M2.5. cc @juzhiyuan This is an automated message from the A

[GitHub] [apisix-dashboard] starsz commented on issue #758: [DISCUSS] Create a new file to generalize error response

2021-01-20 Thread GitBox
starsz commented on issue #758: URL: https://github.com/apache/apisix-dashboard/issues/758#issuecomment-764434972 This will be discussed in M2.4 and finished in M2.5. cc @juzhiyuan This is an automated message from the A

[GitHub] [apisix-dashboard] starsz commented on issue #758: [DISCUSS] Create a new file to generalize error response

2021-01-03 Thread GitBox
starsz commented on issue #758: URL: https://github.com/apache/apisix-dashboard/issues/758#issuecomment-753744831 @juzhiyuan. Not done. I review the code again. There is too much error handler. Like: https://github.com/apache/apisix-dashboard/blob/4f12ae6f8495a441c330

[GitHub] [apisix-dashboard] starsz commented on issue #758: [DISCUSS] Create a new file to generalize error response

2020-11-14 Thread GitBox
starsz commented on issue #758: URL: https://github.com/apache/apisix-dashboard/issues/758#issuecomment-727212074 > We already have a file to place all errors in [here](https://github.com/apache/apisix-dashboard/blob/master/api/internal/utils/consts/error.go) Yeah, I advise creating

[GitHub] [apisix-dashboard] starsz commented on issue #758: [DISCUSS] Create a new file to generalize error response

2020-11-09 Thread GitBox
starsz commented on issue #758: URL: https://github.com/apache/apisix-dashboard/issues/758#issuecomment-724418164 By the way, maybe we can provide a doc to introduce code and message for users. This is an automated message