tokers commented on code in PR #482:
URL: https://github.com/apache/apisix-helm-chart/pull/482#discussion_r1118204113
##########
charts/apisix/values.yaml:
##########
@@ -233,11 +234,13 @@ gateway:
enabled: true
servicePort: 80
containerPort: 9080
+ nodePort: ""
Review Comment:
When using the empty string as the default value of `nodePort`, it might
mislead users to configure a string for `nodePort`. `nodePort` should be an
integer, let's just comment the `nodePort` when we don't need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
