gxthrj commented on a change in pull request #129:
URL:
https://github.com/apache/apisix-ingress-controller/pull/129#discussion_r548428684
##########
File path: docs/develop.md
##########
@@ -89,12 +93,14 @@ spec:
http:
paths:
- backend:
- serviceName: httpserver
+ serviceName: httpbin.default.svc.cluster.local
Review comment:
I found the port of httpbin container is 80, the port should be change
to `80` instead of `8080`.
Or we do need a `service` file to describe the port Mapping.
##########
File path: docs/develop.md
##########
@@ -115,7 +121,7 @@ spec:
http:
paths:
- backend:
- serviceName: httpserver
+ serviceName: httpbin.default.svc.cluster.local
servicePort: 8080
Review comment:
ditto
##########
File path: docs/develop.md
##########
@@ -165,7 +171,7 @@ kubectl apply -f - <<EOF
apiVersion: apisix.apache.org/v1
kind: ApisixUpstream # apisix upstream
metadata:
- name: httpserver # default/httpserver
+ name: httpbin # default/httpbin
spec:
ports:
- port: 8080
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
