[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #262: feat: ApisixRoute v2alpha1

2021-03-02 Thread GitBox
gxthrj commented on a change in pull request #262: URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r586049600 ## File path: test/e2e/ingress/resourcepushing.go ## @@ -64,19 +76,21 @@ spec: ginkgo.It("create and then remove", func() {

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #262: feat: ApisixRoute v2alpha1

2021-02-24 Thread GitBox
gxthrj commented on a change in pull request #262: URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r582535841 ## File path: pkg/ingress/controller/controller.go ## @@ -338,17 +340,6 @@ type Api6Controller struct { Stop