[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1306: feat: support external service

2022-10-20 Thread GitBox
lingsamuel commented on code in PR #1306: URL: https://github.com/apache/apisix-ingress-controller/pull/1306#discussion_r1000221301 ## pkg/providers/apisix/apisix_upstream.go: ## @@ -339,6 +404,114 @@ func (c *apisixUpstreamController) sync(ctx context.Context, ev *types.Event

[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1306: feat: support external service

2022-10-20 Thread GitBox
lingsamuel commented on code in PR #1306: URL: https://github.com/apache/apisix-ingress-controller/pull/1306#discussion_r1000222427 ## pkg/providers/apisix/translation/apisix_upstream.go: ## @@ -47,3 +56,116 @@ func (t *translator) translateService(namespace, svcName, subset,