[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path

2021-12-06 Thread GitBox
lxm commented on a change in pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762862781 ## File path: pkg/kube/translation/ingress.go ## @@ -29,16 +29,23 @@ import ( "github.com/apache/apisix-ingress-controller/pkg/id"

[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path

2021-12-05 Thread GitBox
lxm commented on a change in pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762696561 ## File path: pkg/kube/translation/ingress.go ## @@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing *networkingv1.Ingress)

[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path

2021-12-05 Thread GitBox
lxm commented on a change in pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762570713 ## File path: pkg/kube/translation/ingress.go ## @@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing *networkingv1.Ingress)

[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path

2021-12-05 Thread GitBox
lxm commented on a change in pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r762533120 ## File path: pkg/kube/translation/ingress.go ## @@ -87,29 +94,49 @@ func (t *translator) translateIngressV1(ing *networkingv1.Ingress)

[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path

2021-12-02 Thread GitBox
lxm commented on a change in pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r761098777 ## File path: pkg/kube/translation/annotations/types.go ## @@ -18,6 +18,10 @@ import ( "strings" ) +const ( +

[GitHub] [apisix-ingress-controller] lxm commented on a change in pull request #779: feat: support regex in path

2021-11-30 Thread GitBox
lxm commented on a change in pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#discussion_r759835430 ## File path: pkg/kube/translation/annotations/types.go ## @@ -18,6 +18,10 @@ import ( "strings" ) +const ( +