neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-1000988943
ci show there were errors in e2e case `check the ingress lb status is
updated`
@tao12345666333
--
This is an automated message from the Apache Git
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-1000148691
@tao12345666333
There were still some errors in ci which I should fix it before.
This branch are not accepted.
--
This is an automated message from
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-119172
> > I could fix it at the same time.
>
> Great!
>
> It looks like this is a bug, can you submit a separate PR? Or use a
separate commit for the
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-117205
> Move L282-L286 to the front of L272.
>
> Also, please check other locations in this file at the same time to ensure
that the order of execution is
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-116439
> @neverCase you can check these steps
>
>
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-101428
ping @tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-999516556
I meet a problem.
```sh
2021-12-22T17:18:11+08:00debug ingress/apisix_route.go:312
ApisixRoute add event arrived {"object":
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-998431321
> LGTM Thanks!
>
> I will run CI again.
I'm confused that why the ci run failed some many times.
--
This is an automated message from the
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-998428634
ping @tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997193358
e2e-test-ci failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997175498
@tao12345666333
From the
[https://apisix.apache.org/docs/apisix/architecture-design/plugin-config/](url),
I thought the filed `plugin_config_id`
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-995394153
> You can do it in two steps
>
> 1. First complete the conversion from ApisixPluginConfig to APISIX
> 2. Binding ApisixPluginConfig on ApisixRoute
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-994246184
ping @tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-993136698
@tao12345666333
I had push codes temporarily.
But I can't find the relationship between the TranslatorContext and the
ApisixRoute correctly.
Also in
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-993106051
>
> #792 has been merged.
ok, I will merge it from the master first
--
This is an automated message from the Apache Git Service.
To
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990718925
>
> I think the current PR can be retained.
>
> You can create a new PR and only upgrade ApisixPluginConfig to v2beta3
>
> You
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990714164
> > But the changes about the v2beta3 make me confused, cause my previous pr
about the ApisixPluginConfig was in
> > the v2beta2 directory
>
> Yes,
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990713769
ping @tao12345666333
> > But the changes about the v2beta3 make me confused, cause my previous pr
about the ApisixPluginConfig was in
> > the
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990575890
> Did you merge code from master?
Yes.
But the changes about the v2beta3 make me confused, cause my previous pr
about the ApisixPluginConfig was in
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990575780
> Details
Yes.
But the changes about the v2beta3 make me confused, cause my previous pr
about the ApisixPluginConfig was in
the v2beta2 directory
neverCase commented on pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-989803554
@tao12345666333
I update it temporarily.
Please review it
--
This is an automated message from the Apache Git Service.
To respond to the message,
21 matches
Mail list logo
