[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r774833974 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: Since this is a bug, I hope to merge it into v

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r774512823 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: ```suggestion ``` This line should be re

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r770225111 ## File path: test/e2e/chaos/chaos.go ## @@ -0,0 +1,71 @@ +package chaos Review comment: @nic-6443 please add license head

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r763124136 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: @tokers any update? -- This is an automa

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r759998449 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: ping @tokers -- This is an automated mes

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r758872053 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: You haven't pushed the latest code yet? --

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r757745597 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: This is new in 1.17, I want to delete it befor