[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1306: feat: support external service

2022-10-20 Thread GitBox
tao12345666333 commented on code in PR #1306: URL: https://github.com/apache/apisix-ingress-controller/pull/1306#discussion_r1000165361 ## pkg/providers/apisix/apisix_upstream.go: ## @@ -339,6 +404,114 @@ func (c *apisixUpstreamController) sync(ctx context.Context, ev

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1306: feat: support external service

2022-10-16 Thread GitBox
tao12345666333 commented on code in PR #1306: URL: https://github.com/apache/apisix-ingress-controller/pull/1306#discussion_r991890144 ## pkg/providers/apisix/apisix_upstream.go: ## @@ -242,6 +280,30 @@ func (c *apisixUpstreamController) sync(ctx context.Context, ev