tao12345666333 commented on pull request #772:
URL:
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-988586877
Good job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
tao12345666333 commented on pull request #772:
URL:
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-988576890
#788 has fixed the e2e error. It's green!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
tao12345666333 commented on pull request #772:
URL:
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-984438621
> Mostly LGTM but some import block style problems.
@neverCase can you improve the code style?
--
This is an automated message from the Apache Gi
tao12345666333 commented on pull request #772:
URL:
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-983577973
ping @gxthrj @tokers for review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
tao12345666333 commented on pull request #772:
URL:
https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-983448305
@neverCase Sorry for delay. I leave some comments, I hope you can make
changes
--
This is an automated message from the Apache Git Service.
To respond