[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-09 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r553936441 ## File path: charts/ingress-apisix/templates/service.yaml ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-08 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r553936441 ## File path: charts/ingress-apisix/templates/service.yaml ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-07 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r553690642 ## File path: charts/base/templates/rbac.yaml ## @@ -0,0 +1,179 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552346513 ## File path: charts/base/templates/rbac.yaml ## @@ -0,0 +1,179 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552341599 ## File path: charts/ingress-apisix/values.yaml ## @@ -0,0 +1,66 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552341311 ## File path: charts/ingress-apisix/templates/deployment.yaml ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) u

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552339673 ## File path: charts/ingress-apisix/values.yaml ## @@ -0,0 +1,66 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552339129 ## File path: charts/base/templates/rbac.yaml ## @@ -0,0 +1,179 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552301395 ## File path: charts/ingress-apisix/templates/deployment.yaml ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) u

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552301266 ## File path: charts/ingress-apisix/templates/deployment.yaml ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) u

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552300356 ## File path: charts/ingress-apisix/templates/service.yaml ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r552297895 ## File path: charts/base/templates/_helpers.tpl ## @@ -0,0 +1,51 @@ +{{/* +Expand the name of the chart. Review comment: OK, will

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551810925 ## File path: charts/base/Chart.yaml ## @@ -0,0 +1,26 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-05 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551808371 ## File path: charts/base/Chart.yaml ## @@ -0,0 +1,26 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551760445 ## File path: charts/ingress-apisix/templates/tests/test-connection.yaml ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundat

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551749012 ## File path: charts/ingress-apisix/values.yaml ## @@ -0,0 +1,87 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551747804 ## File path: docs/install.md ## @@ -54,7 +54,19 @@ kubectl apply -k /path/to/apisix-ingress-controller/samples/deploy ## Helm -// t

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551747610 ## File path: charts/ingress-apisix/templates/deployment.yaml ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) u