tokers commented on a change in pull request #173:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/173#discussion_r557066783



##########
File path: test/e2e/scaffold/httpbin.go
##########
@@ -112,3 +115,32 @@ func (s *Scaffold) ScaleHTTPBIN(desired int) error {
        }
        return nil
 }
+
+// WaitAllHTTPBINPods waits until all httpbin pods ready.
+func (s *Scaffold) WaitAllHTTPBINPoddsAvailable() error {

Review comment:
       It just checks number of Pods are created, not number of Pods are ready.
   
   What we need is the latter, since only a Pod is ready, can it exists in the 
Endpoints ready addresses.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to