[GitHub] [apisix-ingress-controller] tokers commented on pull request #774: fix: delete the cluster object when give up the leadership

2021-11-29 Thread GitBox
tokers commented on pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-982206376 > better to add e2e for this feature. First of all, this is not a feature, indeed it's a bugfix, also, it's tough to add cases for it. -- This is an aut

[GitHub] [apisix-ingress-controller] tokers commented on pull request #774: fix: delete the cluster object when give up the leadership

2021-11-26 Thread GitBox
tokers commented on pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-979795678 > > CI failed. > > The go version on my local is `1.17` and the build directive is different. I use the go/1.16.10 to re-generate some files. -- T

[GitHub] [apisix-ingress-controller] tokers commented on pull request #774: fix: delete the cluster object when give up the leadership

2021-11-26 Thread GitBox
tokers commented on pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-979791107 > CI failed. The go version on my local is `1.17` and the build directive is different. -- This is an automated message from the Apache Git Service. To r