[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #158: feat: support hot reload of Java plugins

2022-07-17 Thread GitBox
tzssangglass commented on PR #158: URL: https://github.com/apache/apisix-java-plugin-runner/pull/158#issuecomment-1186653974 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #158: feat: support hot reload of Java plugins

2022-07-08 Thread GitBox
tzssangglass commented on PR #158: URL: https://github.com/apache/apisix-java-plugin-runner/pull/158#issuecomment-1179270075 > How should I begin writing documentation for this? Is there a guideline I should follow. we can refer to: https://github.com/apache/apisix-java-plugin-runne

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #158: feat: support hot reload of Java plugins

2022-07-04 Thread GitBox
tzssangglass commented on PR #158: URL: https://github.com/apache/apisix-java-plugin-runner/pull/158#issuecomment-1173883439 We need to add documentation to explain how this feature should be used. And add test cases to verify it (test cases can be done later). -- This is an automated me

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #158: feat: support hot reload of Java plugins

2022-06-30 Thread GitBox
tzssangglass commented on PR #158: URL: https://github.com/apache/apisix-java-plugin-runner/pull/158#issuecomment-1171980483 Hi @ericluoliu ,pls take a look at CI failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us