[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r401348100 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -29,7 +29,17 @@

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r401348180 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -29,7 +29,17 @@

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400664895 ## File path: doc/plugins/zipkin-cn.md ## @@ -118,3 +120,45 @@ $ curl

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400665182 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -29,7 +29,12 @@

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400664423 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -131,6 +144,9 @@

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400664408 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -94,6 +99,8 @@

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400587909 ## File path: doc/plugins/zipkin-cn.md ## @@ -34,8 +34,9 @@ ## 属性

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400587821 ## File path: doc/plugins/zipkin.md ## @@ -39,6 +39,7 @@ It's also

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400074628 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -109,6 +130,10 @@