[GitHub] [incubator-apisix] spacewander commented on issue #1305: chore: improve plugins/proxy-cache

2020-03-22 Thread GitBox
spacewander commented on issue #1305: chore: improve plugins/proxy-cache URL: https://github.com/apache/incubator-apisix/pull/1305#issuecomment-602398464 @agile6v I see. I figure out that `proxy_no_cache` is skipped when the upstream finalized with 502 or 504. It seems that there is

[GitHub] [incubator-apisix] spacewander commented on issue #1305: chore: improve plugins/proxy-cache

2020-03-19 Thread GitBox
spacewander commented on issue #1305: chore: improve plugins/proxy-cache URL: https://github.com/apache/incubator-apisix/pull/1305#issuecomment-601536988 @membphis Just realize one more thing: we might need to blacklist `ngx.var.request_method` (or document them) in the

[GitHub] [incubator-apisix] spacewander commented on issue #1305: chore: improve plugins/proxy-cache

2020-03-19 Thread GitBox
spacewander commented on issue #1305: chore: improve plugins/proxy-cache URL: https://github.com/apache/incubator-apisix/pull/1305#issuecomment-601507279 BTW, the doc mentions that the `502` and `504` returned by APISIX will be cached. However, the `cache_http_status` is configurable and