moonming commented on pull request #257: URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#issuecomment-643269935
yes, we need the asf header 琚致远 <notificati...@github.com> 于 2020年6月12日周五 下午9:16写道： > *@juzhiyuan* requested changes on this pull request. > ------------------------------ > > In compose/grafana_conf/provisioning/dashboards/all.yaml > <https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439411241> > : > > > @@ -0,0 +1,11 @@ > +apiVersion: 1 > + > +providers: > +- name: 'default' > + orgId: 1 > + folder: '' > + type: file > + disableDeletion: false > + editable: false > + options: > + path: /var/lib/grafana/dashboards > > It should be dashboard > ------------------------------ > > In api/build.sh > <https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439411495> > : > > > @@ -1,20 +1,3 @@ > -# > -# Licensed to the Apache Software Foundation (ASF) under one or more > > @moonming <https://github.com/moonming> We may still need this header, > right? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-apisix-dashboard/pull/257#pullrequestreview-429730171>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AGJZBK2GNTQ2JBVCA7BYYRTRWITCLANCNFSM4N4G4IRQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
