Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 4: Integration-Tests+1
Integration Tests Successful
Yingyi Bu has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
(1 comment)
abdullah alamoudi has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
(1 comment)
abdullah alamoudi has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3:
I think it should be removed from the node controller service as well.
the reason is that I don't think we
abdullah alamoudi has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(1 comment)
Yingyi Bu has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(1 comment)
Yingyi Bu has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
(1 comment)
Just saw this change. Pls ignore my comment for moving the node controlller
Yingyi Bu has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 4:
(6 comments)
Yingyi Bu has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3: Code-Review+2
It's slightly more intuitive to me if the shutdown hook is added in the
NCDriver as NCDriver is the
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 4:
Integration Tests Started
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 4:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3196/
--
To view, visit
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1325
to look at the new patch set (#4).
Change subject: Extract IPCIs out of ClusterControllerService
..
Extract IPCIs
Jenkins has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1: Integration-Tests+1
Integration Tests Successful
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3195/
--
To view, visit
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1325
to look at the new patch set (#3).
Change subject: Extract IPCIs out of ClusterControllerService
..
Extract IPCIs
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3194/
--
To view, visit
abdullah alamoudi has uploaded a new patch set (#2).
Change subject: Extract IPCIs out of ClusterControllerService
..
Extract IPCIs out of ClusterControllerService
moving the two IPCIs out of cluster controller service is a
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1325
Change subject: Extract IPCIs out of ClusterControllerService
..
Extract IPCIs out of ClusterControllerService
moving the two
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3: Integration-Tests+1
Integration Tests Successful
Jenkins has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
Integration Tests Started
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1047/
--
To view,
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 4: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1046/
Jenkins has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3192/
--
To
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1324
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Extract NodeControllerIPCI out of
Jenkins has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 2: Integration-Tests+1
Integration Tests Successful
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3191/
--
To view, visit
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1323
to look at the new patch set (#3).
Change subject: Remove Redundant Shutdown Hook
..
Remove Redundant Shutdown Hook
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3190/
--
To view, visit
abdullah alamoudi has uploaded a new patch set (#2).
Change subject: Remove Redundant Shutdown Hook
..
Remove Redundant Shutdown Hook
Currently, when we start a NodeControllerService, we add
its shutdown hook to the runtime.
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 1:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3189/
--
To view, visit
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1323
Change subject: Remove Redundant Shutdown Hook
..
Remove Redundant Shutdown Hook
Currently, when we start a
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 4:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1046/
--
To view, visit
Jenkins has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 2:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1045/
--
To view,
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 4:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3188/
--
To view, visit
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1320
to look at the new patch set (#4).
Change subject: Remove Server Context
..
Remove Server Context
Change-Id:
Jenkins has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 2:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK
Jenkins has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3187/
--
To view, visit
Hello Till Westmann, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1321
to look at the new patch set (#2).
Change subject: Remove HyracksRootContext
..
Remove
abdullah alamoudi has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 1:
(1 comment)
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3186/
--
To view, visit
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1320
to look at the new patch set (#3).
Change subject: Remove Server Context
..
Remove Server Context
Change-Id:
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(3 comments)
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3185/
--
To view, visit
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1320
to look at the new patch set (#2).
Change subject: Remove Server Context
..
Remove Server Context
Change-Id:
Jenkins has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 9: Integration-Tests+1
Integration Tests Successful
Jenkins has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 9:
Integration Tests Started
Jenkins has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 9:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
*
Jenkins has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 9:
Build Started
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1313
to look at the new patch set (#9).
Change subject: Unify runtime type exceptions by using error code and message
template.
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 5: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1043/
:
Till Westmann has posted comments on this change.
Change subject: Reorganize Replication Properties For HTTP API
..
Patch Set 1:
Filed https://issues.apache.org/jira/browse/ASTERIXDB-1719 as a follow-up.
--
To view, visit
Till Westmann has posted comments on this change.
Change subject: Reorganize Replication Properties For HTTP API
..
Patch Set 1: Code-Review+2
(1 comment)
Till created ASTERIXDB-1719:
---
Summary: Clean up conventions for HTTP requests in tests
Key: ASTERIXDB-1719
URL: https://issues.apache.org/jira/browse/ASTERIXDB-1719
Project: Apache AsterixDB
Issue
Yingyi Bu has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
Again, moving the inner class ClusterControllerContext out would be nice, if
you can do so. But inlining baseDir into
Yingyi Bu has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
>> too many contexts = confusion.
>> not only for existing developers but also for new ones.
I don't think they really cause
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
Also, forgot the IHyracksRootContext which was a wrapper for IOManager :S
--
To view, visit
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
For the SonarQube argument, show me a place where having the
ICCContext or the ServerContext will get rid of that.
We
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
too many contexts = confusion. not only for existing developers but also for
new ones.
and those are wrappers with
Yingyi Bu has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(1 comment)
In short, I think the design of context classes are well conceived. Yes, it
might not be fully utilized for today's
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 5:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR API
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(1 comment)
abdullah alamoudi has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 8:
(1 comment)
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 5:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3183/
--
To view, visit
Hello Michael Blow, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1322
to look at the new patch set (#5).
Change subject: Remove ICCContext
..
Remove ICCContext
Change-Id:
abdullah alamoudi has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(3 comments)
Yingyi Bu has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(1 comment)
I like various context classes.
At the high level, it provides:
(1) a facet for separating concerns and
[
https://issues.apache.org/jira/browse/ASTERIXDB-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenhai updated ASTERIXDB-1718:
--
Issue Type: Improvement (was: Bug)
> Condition expression propagation in general cases.
>
Wenhai created ASTERIXDB-1718:
-
Summary: Condition expression propagation in general cases.
Key: ASTERIXDB-1718
URL: https://issues.apache.org/jira/browse/ASTERIXDB-1718
Project: Apache AsterixDB
Yingyi Bu has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 8:
(1 comment)
Yingyi Bu has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(3 comments)
abdullah alamoudi has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 8:
(1 comment)
Can we list the new exception classes created in the
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR API
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3182/
--
To view, visit
abdullah alamoudi has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2:
The motivation is to get rid of yet another confusing context.
The ICCContext is just a wrapper for cluster topology
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 3:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR API
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3181/
--
To view, visit
Hello Michael Blow, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1322
to look at the new patch set (#3).
Change subject: Remove ICCContext
..
Remove ICCContext
Change-Id:
Michael Blow has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2: Code-Review-1
This change seems to regress code cleanliness and readability by requiring
casts all over the place- can you
Michael Blow has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(1 comment)
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..
Patch Set 3: Integration-Tests+1
Integration Tests Successful
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..
Patch Set 3:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1042/
--
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1041/
:
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3180/
--
To view, visit
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1314
to look at the new patch set (#3).
Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..
ASTERIXDB-1711:
Till Westmann has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1321
To unsubscribe, visit
Till Westmann has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 1:
(1 comment)
Till Westmann has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(3 comments)
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1041/
--
To view, visit
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR API
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3179/
--
To view, visit
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1322
to look at the new patch set (#2).
Change subject: Remove ICCContext
..
Remove ICCContext
Change-Id:
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 1:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR API
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 1:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3178/
--
To view, visit
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1322
Change subject: Remove ICCContext
..
Remove ICCContext
Change-Id: I6f6a769741f14e91bcd4b970b4a022c0a453d380
---
M
94 matches
Mail list logo
