Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 4: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-
Yingyi Bu has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1324/1/hyracks-fullstack/hyracks/hyracks-
abdullah alamoudi has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1324/1/hyracks-fullstack/hyracks/
abdullah alamoudi has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3:
I think it should be removed from the node controller service as well.
the reason is that I don't think we wan
abdullah alamoudi has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1322/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src
Yingyi Bu has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1322/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/ja
Yingyi Bu has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
(1 comment)
Just saw this change. Pls ignore my comment for moving the node controlller
ip
Yingyi Bu has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 4:
(6 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1325/4/hyracks-fullstack/hyracks/hyracks-control/h
Yingyi Bu has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3: Code-Review+2
It's slightly more intuitive to me if the shutdown hook is added in the
NCDriver as NCDriver is the pro
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 4:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1049/
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 4:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3196/
--
To view, visit h
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1325
to look at the new patch set (#4).
Change subject: Extract IPCIs out of ClusterControllerService
..
Extract IPCIs out
Jenkins has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/aster
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3195/
--
To view, visit h
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1325
to look at the new patch set (#3).
Change subject: Extract IPCIs out of ClusterControllerService
..
Extract IPCIs out
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3194/
--
To view, visit h
abdullah alamoudi has uploaded a new patch set (#2).
Change subject: Extract IPCIs out of ClusterControllerService
..
Extract IPCIs out of ClusterControllerService
moving the two IPCIs out of cluster controller service is a good
Jenkins has posted comments on this change.
Change subject: Extract IPCIs out of ClusterControllerService
..
Patch Set 1:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3193/
--
To view, visit h
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1325
Change subject: Extract IPCIs out of ClusterControllerService
..
Extract IPCIs out of ClusterControllerService
moving the two IPC
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tes
Jenkins has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-t
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1047/
--
To view,
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 4: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1046/
Jenkins has posted comments on this change.
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Patch Set 1:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3192/
--
To vie
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1324
Change subject: Extract NodeControllerIPCI out of NodeControllerService
..
Extract NodeControllerIPCI out of NodeControllerService
Jenkins has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 2: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/10
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3191/
--
To view, visit https://asterix-
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1323
to look at the new patch set (#3).
Change subject: Remove Redundant Shutdown Hook
..
Remove Redundant Shutdown Hook
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3190/
--
To view, visit https://asterix-
abdullah alamoudi has uploaded a new patch set (#2).
Change subject: Remove Redundant Shutdown Hook
..
Remove Redundant Shutdown Hook
Currently, when we start a NodeControllerService, we add
its shutdown hook to the runtime. The
Jenkins has posted comments on this change.
Change subject: Remove Redundant Shutdown Hook
..
Patch Set 1:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3189/
--
To view, visit https://asterix-
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1323
Change subject: Remove Redundant Shutdown Hook
..
Remove Redundant Shutdown Hook
Currently, when we start a NodeControllerService
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 4:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1046/
--
To view, visit htt
Jenkins has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 2:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1045/
--
To view, visit
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 4:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3188/
--
To view, visit https://asterix-gerrit.ic
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1320
to look at the new patch set (#4).
Change subject: Remove Server Context
..
Remove Server Context
Change-Id: I4261cf
Jenkins has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 2:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR
Jenkins has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3187/
--
To view, visit https://asterix-gerri
Hello Till Westmann, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1321
to look at the new patch set (#2).
Change subject: Remove HyracksRootContext
..
Remove HyracksRootCont
abdullah alamoudi has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1321/1/hyracks-fullstack/hyracks/hyracks-test-support/src/main/
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3186/
--
To view, visit https://asterix-gerrit.ic
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1320
to look at the new patch set (#3).
Change subject: Remove Server Context
..
Remove Server Context
Change-Id: I4261cf
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1320/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-c
Jenkins has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 2:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3185/
--
To view, visit https://asterix-gerrit.ic
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1320
to look at the new patch set (#2).
Change subject: Remove Server Context
..
Remove Server Context
Change-Id: I4261cf
Jenkins has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 9: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.
Jenkins has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 9:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-ger
Jenkins has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 9:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-
Jenkins has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 9:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1313
to look at the new patch set (#9).
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 5: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1043/
: S
Till Westmann has posted comments on this change.
Change subject: Reorganize Replication Properties For HTTP API
..
Patch Set 1:
Filed https://issues.apache.org/jira/browse/ASTERIXDB-1719 as a follow-up.
--
To view, visit htt
Till Westmann has posted comments on this change.
Change subject: Reorganize Replication Properties For HTTP API
..
Patch Set 1: Code-Review+2
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1319/1/asterixdb/asterix-app/src
Till created ASTERIXDB-1719:
---
Summary: Clean up conventions for HTTP requests in tests
Key: ASTERIXDB-1719
URL: https://issues.apache.org/jira/browse/ASTERIXDB-1719
Project: Apache AsterixDB
Issue
Yingyi Bu has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
Again, moving the inner class ClusterControllerContext out would be nice, if
you can do so. But inlining baseDir into Cluster
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
NoddControllerService and ClusterControllerService are semi kitchen sinks right
now and I am stopping that from happen
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 5:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1043/
--
To view, visit https:/
Yingyi Bu has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
>> too many contexts = confusion.
>> not only for existing developers but also for new ones.
I don't think they really cause
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
Also, forgot the IHyracksRootContext which was a wrapper for IOManager :S
--
To view, visit https://asterix-gerrit.ic
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
For the SonarQube argument, show me a place where having the
ICCContext or the ServerContext will get rid of that.
We
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
too many contexts = confusion. not only for existing developers but also for
new ones.
and those are wrappers with unu
Yingyi Bu has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(1 comment)
In short, I think the design of context classes are well conceived. Yes, it
might not be fully utilized for today's
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 5:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR API CHA
abdullah alamoudi has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1320/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apac
abdullah alamoudi has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 8:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1313/8/asterixdb
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 5:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3183/
--
To view, visit https://asterix-gerrit.ics.uc
Hello Michael Blow, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1322
to look at the new patch set (#5).
Change subject: Remove ICCContext
..
Remove ICCContext
Change-Id: I
abdullah alamoudi has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1322/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runt
Yingyi Bu has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(1 comment)
I like various context classes.
At the high level, it provides:
(1) a facet for separating concerns and modular
[
https://issues.apache.org/jira/browse/ASTERIXDB-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenhai updated ASTERIXDB-1718:
--
Issue Type: Improvement (was: Bug)
> Condition expression propagation in general cases.
> -
Wenhai created ASTERIXDB-1718:
-
Summary: Condition expression propagation in general cases.
Key: ASTERIXDB-1718
URL: https://issues.apache.org/jira/browse/ASTERIXDB-1718
Project: Apache AsterixDB
Yingyi Bu has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 8:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1313/8/asterixdb/asterix
Yingyi Bu has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1322/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util
abdullah alamoudi has posted comments on this change.
Change subject: Unify runtime type exceptions by using error code and message
template.
..
Patch Set 8:
(1 comment)
Can we list the new exception classes created in the ch
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR API CHA
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 4:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3182/
--
To view, visit https://asterix-gerrit.ics.uc
Hello Michael Blow, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1322
to look at the new patch set (#4).
Change subject: Remove ICCContext
..
Remove ICCContext
Change-Id: I
abdullah alamoudi has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2:
The motivation is to get rid of yet another confusing context.
The ICCContext is just a wrapper for cluster topology (which
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 3:
WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack
PLEASE REVIEW CAREFULLY AND LOOK FOR API CHA
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3181/
--
To view, visit https://asterix-gerrit.ics.uc
Hello Michael Blow, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1322
to look at the new patch set (#3).
Change subject: Remove ICCContext
..
Remove ICCContext
Change-Id: I
Michael Blow has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2: Code-Review-1
This change seems to regress code cleanliness and readability by requiring
casts all over the place- can you expl
Michael Blow has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1320/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..
Patch Set 3: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integ
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..
Patch Set 3:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1042/
--
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1041/
: S
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..
Patch Set 3:
Build Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3180/
--
To view, visit https:
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1314
to look at the new patch set (#3).
Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..
ASTERIXDB-1711: remove
Till Westmann has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1321
To unsubscribe, visit https://asterix-gerrit.i
Till Westmann has posted comments on this change.
Change subject: Remove HyracksRootContext
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1321/1/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java
Till Westmann has posted comments on this change.
Change subject: Remove Server Context
..
Patch Set 1:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1320/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/
Jenkins has posted comments on this change.
Change subject: Remove ICCContext
..
Patch Set 2:
Integration Tests Started
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1041/
--
To view, visit https:/
92 matches
Mail list logo
