Change in asterixdb[master]: [ASTERIXDB-2579][DOC] Document uuid/upsert/insert behavior

2019-05-28 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3414 ) Change subject: [ASTERIXDB-2579][DOC] Document uuid/upsert/insert behavior .. Patch Set 2: (6 comments) https://asterix-gerrit.ics.

Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Michael Carey (Code Review)
Michael Carey has submitted this change and it was merged. Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer .. [ASTERIXDB-2456][DOC] Re-add insert to primer Change-Id: I404246ea4a8568e28190cd2371356175db1471cc Revi

Change in asterixdb[master]: [ASTERIXDB-2456][DOC] Re-add insert to primer

2018-10-02 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: [ASTERIXDB-2456][DOC] Re-add insert to primer .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2983 To unsubscribe, visit http

Change in asterixdb[master]: Document the Query Service API

2017-04-26 Thread Michael Carey (Code Review)
Michael Carey has submitted this change and it was merged. Change subject: Document the Query Service API .. Document the Query Service API Change-Id: Ifcefb1671ea305a5958c9a74a588b4aaa17f399f Reviewed-on: https://asterix-gerri

Change in asterixdb[master]: Document the Query Service API

2017-04-26 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: Document the Query Service API .. Patch Set 5: Code-Review+2 Correcting a sign bit error. :-) -- To view, visit https://asterix-gerrit.ics.uci.edu/1698 To unsu

Change in asterixdb[master]: Document the Query Service API

2017-04-25 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: Document the Query Service API .. Patch Set 4: Code-Review-2 (1 comment) (Found one last tiny typo, but it looks good!) https://asterix-gerrit.ics.uci.edu/#/c/

Change in asterixdb[master]: Document the Query Service API

2017-04-23 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: Document the Query Service API .. Patch Set 1: (4 comments) I've added a few comments... https://asterix-gerrit.ics.uci.edu/#/c/1698/1/asterixdb/asterix-doc/sr

Change in asterixdb[master]: Added some info about open and close types to the data model...

2017-02-16 Thread Michael Carey (Code Review)
Michael Carey has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1510 Change subject: Added some info about open and close types to the data model doc. Change-Id: I1262090a2a568d935fd96e00db1da5cd836f25a5 ...

Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for d...

2017-02-07 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for distributed jobs .. Patch Set 11: Actually, regarding "Addressed comments. As far as tests go, the fu

Change in incubator-asterixdb-site[asf-site]: Remove javascript SDK doc

2017-01-19 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: Remove javascript SDK doc .. Patch Set 1: Code-Review+2 Looks great! -- To view, visit https://asterix-gerrit.ics.uci.edu/1455 To unsubscribe, visit https://as

Change in asterixdb[master]: Cleaning up typos and clarifying examples in string function...

2016-12-21 Thread Michael Carey (Code Review)
Michael Carey has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1403 Change subject: Cleaning up typos and clarifying examples in string function doc. .. Cleaning up typos and clarifying examples in str

Change in asterixdb[master]: Fixing some doc bugs related to numeric functions.

2016-12-15 Thread Michael Carey (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1312 to look at the new patch set (#4). Change subject: Fixing some doc bugs related to numeric functions. .. Fixing some

Change in asterixdb[master]: Fixing some doc bugs related to numeric functions.

2016-12-15 Thread Michael Carey (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1312 to look at the new patch set (#3). Change subject: Fixing some doc bugs related to numeric functions. .. Fixing some

Change in asterixdb[master]: Fixing some doc bugs related to numeric functions.

2016-10-25 Thread Michael Carey (Code Review)
Michael Carey has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1312 Change subject: Fixing some doc bugs related to numeric functions. .. Fixing some doc bugs related to numeric functions. Change-Id: I

Change in asterixdb[master]: Making the SQL++ reference manual a bit more generic in how ...

2016-10-02 Thread Michael Carey (Code Review)
Michael Carey has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1237 Change subject: Making the SQL++ reference manual a bit more generic in how it reads. .. Making the SQL++ reference manual a bit more

Change in asterixdb[master]: Minor edits to LET, UNION ALL, and SQL++ vs. SQL table.

2016-09-23 Thread Michael Carey (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1200 to look at the new patch set (#2). Change subject: Minor edits to LET, UNION ALL, and SQL++ vs. SQL table. .. Minor e

Change in asterixdb[master]: Minor updates to the reference material for SQL++.

2016-09-22 Thread Michael Carey (Code Review)
Michael Carey has abandoned this change. Change subject: Minor updates to the reference material for SQL++. .. Abandoned Oops. Sorry. Shouldn't have submitted this change this way! -- To view, visit https://asterix-gerrit.i

Change in asterixdb[master]: Separate submit of minor edits to LET, UNION ALL, and SQL++ ...

2016-09-22 Thread Michael Carey (Code Review)
Michael Carey has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1200 Change subject: Separate submit of minor edits to LET, UNION ALL, and SQL++ vs. SQL table. .. Separate submit of minor edits to LET,

Change in asterixdb[master]: Minor updates to the reference material for SQL++.

2016-09-22 Thread Michael Carey (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1131 to look at the new patch set (#4). Change subject: Minor updates to the reference material for SQL++. .. Minor update

Change in asterixdb[master]: Updating the new 101 tutorial's link for SQL++.

2016-09-22 Thread Michael Carey (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1131 to look at the new patch set (#3). Change subject: Updating the new 101 tutorial's link for SQL++. .. Updating the ne

Change in asterixdb[master]: Updating the new 101 tutorial for SQL++.

2016-09-22 Thread Michael Carey (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1131 to look at the new patch set (#2). Change subject: Updating the new 101 tutorial for SQL++. .. Updating the new 101 t

Change in asterixdb[master]: Enhanced Insert AQL

2016-09-16 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: I couldn't figure out how to publish my comment on Till's comment - but the gist is I like the variant: insert into datase

Change in asterixdb[master]: Enhanced Insert AQL

2016-09-16 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: I added a comment on the syntax - I would like to second Till's change (modulo finalizing the var-binding syntax). -- To

Change in asterixdb[master]: Enhanced Insert AQL

2016-09-16 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: Enhanced Insert AQL .. Patch Set 10: Code-Review-1 I added a common on the syntax - I would like to second Till's change (modulo finalizing the var-binding synt

Change in asterixdb[master]: Adding a new 101 tutorial for SQL++.

2016-08-30 Thread Michael Carey (Code Review)
Michael Carey has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1131 Change subject: Adding a new 101 tutorial for SQL++. .. Adding a new 101 tutorial for SQL++. Includes SQL++ versions of all 101 queri

Change in asterixdb[master]: Fix open field CREATE INDEX syntax (AQL and SQLPP).

2016-08-26 Thread Michael Carey (Code Review)
Michael Carey has submitted this change and it was merged. Change subject: Fix open field CREATE INDEX syntax (AQL and SQLPP). .. Fix open field CREATE INDEX syntax (AQL and SQLPP). Our CREATE INDEX syntax for open fields didn'

Change in asterixdb[master]: Fix open field CREATE INDEX syntax (AQL and SQLPP).

2016-08-26 Thread Michael Carey (Code Review)
Hello Till Westmann, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1106 to look at the new patch set (#3). Change subject: Fix open field CREATE INDEX syntax (AQL and SQLPP).

Change in asterixdb[master]: Fix open field CREATE INDEX syntax (AQL and SQLPP).

2016-08-25 Thread Michael Carey (Code Review)
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1106 to look at the new patch set (#2). Change subject: Fix open field CREATE INDEX syntax (AQL and SQLPP). .. Fix open fi

Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.

2016-08-24 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Code-Review+1 Since I'm a novice reviewer, I won't +2 it, but I would if I had more

Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.

2016-08-24 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: Looked at the code and plans - looks good to me. (Got a jump start in person duri

Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.

2016-08-24 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. .. Patch Set 6: NOTE: A number of the (optimizer only) test cases affected by this change were pr

Change in asterixdb[master]: Change to create syntax for open indices - both for AQL and ...

2016-08-23 Thread Michael Carey (Code Review)
Michael Carey has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1106 Change subject: Change to create syntax for open indices - both for AQL and SQLPP. .. Change to create syntax for open indices - both

Change in asterixdb[master]: ASTERIXDB-1528: fix 101 query 6 and 7.

2016-08-12 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1528: fix 101 query 6 and 7. .. Patch Set 3: (2 comments) Just looked at this - suggested a very small wording change as well as an optional addition

Change in asterixdb[master]: Making the web UI language neutral :-)

2016-07-19 Thread Michael Carey (Code Review)
Michael Carey has submitted this change and it was merged. Change subject: Making the web UI language neutral :-) .. Making the web UI language neutral :-) Change-Id: Ia1035066170b5da5ab6839e6989b46d72e6c89e2 Reviewed-on: https

Change in asterixdb[master]: Making the web UI language neutral :-)

2016-07-19 Thread Michael Carey (Code Review)
Michael Carey has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1007 Change subject: Making the web UI language neutral :-) .. Making the web UI language neutral :-) Change-Id: Ia1035066170b5da5ab6839e6

Change in incubator-asterixdb-site[asf-site]: Update dev-setup to use IntelliJ instead

2016-07-19 Thread Michael Carey (Code Review)
Michael Carey has posted comments on this change. Change subject: Update dev-setup to use IntelliJ instead .. Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1005/2/dev-setup.md File dev-setup.md: Line 32: ##