Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/38#issuecomment-172702066
@eiri good, thanks for explanation. LGFM except one minor naming issue.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/38#discussion_r50063995
--- Diff: src/couch_mrview_util.erl ---
@@ -341,18 +323,9 @@ all_docs_reduce_to_count(Reductions) ->
reduce_to_count(nil) ->
0;
[
https://issues.apache.org/jira/browse/COUCHDB-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106064#comment-15106064
]
Alexander Shorin commented on COUCHDB-2931:
---
I don't think anything need to be
[
https://issues.apache.org/jira/browse/COUCHDB-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105983#comment-15105983
]
Robert Kowalski commented on COUCHDB-2931:
--
I am sorry, I do not understand.
C
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/610
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/611
Minor CSS tweaks
After speaking with Justin, I made a small tweak to the
header CSS which ensures the spacing between the API and
OPTIONS header buttons and their icons was consisten
[
https://issues.apache.org/jira/browse/COUCHDB-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105795#comment-15105795
]
Paul Hammant commented on COUCHDB-2923:
---
As I've just updated in ERL-74, this was
[
https://issues.apache.org/jira/browse/COUCHDB-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105580#comment-15105580
]
Eric Avdey commented on COUCHDB-2748:
-
Well, I definitely not agree with the second
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#issuecomment-172584006
thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#discussion_r50020251
--- Diff: app/addons/documents/header/header.react.jsx ---
@@ -43,7 +43,7 @@ function (app, FauxtonAPI, React, Actions,
ReactComponents,
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#discussion_r50020176
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -83,14 +97,15 @@ function (app, FauxtonAPI, React, Stores, Actions,
Compone
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#issuecomment-172583189
code looks good, +1 after addressing the classname issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#discussion_r50019823
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -83,14 +97,15 @@ function (app, FauxtonAPI, React, Stores, Actions,
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#discussion_r50019691
--- Diff: app/addons/documents/header/header.react.jsx ---
@@ -43,7 +43,7 @@ function (app, FauxtonAPI, React, Actions,
ReactComponents,
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/610
Minor extensibility tweaks
This PR contains a bunch of really small unrelated changes
for general extensibility.
- optional top-level class added to Tray component
- QueryOptions
[
https://issues.apache.org/jira/browse/COUCHDB-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105475#comment-15105475
]
Robert Kowalski commented on COUCHDB-2748:
--
Just a response with malformed_requ
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/607#issuecomment-172538610
i don't have a very strong opinion regarding the periods. hmm...
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/608#issuecomment-172538437
merged as 7410de9fa0917dd1a6bfb6937fbcc24ca387e56b
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/COUCHDB-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105325#comment-15105325
]
Eric Avdey commented on COUCHDB-2748:
-
Just to confirm that I've got you correctly -
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/606
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/606#issuecomment-172534813
merged as e221bcd01dd8a173f8e7830200cd3c4615a67d05
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/38#issuecomment-172532470
@kxepal Thank you!
I'm afraid it's not feasible to completely get rid of closures there. We
are calling functor `couch_btree:final_reduce/2` which acc
23 matches
Mail list logo
