Github user justin-mcdavid-ibm commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/741
This great functionality to add, @samk1. Thanks for your time in working
on this.
While testing, I found that file information is disappearing behind the
scroll bar
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
@rnewson yes, you're right here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/743
display not exist error just on 404
just in case of a 404 the notification "The document does not
exist" is relevant.
You can merge this pull request into a Git repository by
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
@kxepal I hope it's also clear that the socket is _never_ a pid, that's the
mistake, it's a port in the non-ssl case and a tuple, {ssl, blah, port, ...} if
ssl.
---
If your project is set
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
We'd want them to match, though. In my opinion the version in couch_httpd
is quite clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
But it's too late anyway, so ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
@rnewson that doesn't means that it couldn't be improved (;
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
@kxepal The new code reflects exactly what couchdb has always done since
2012 (that code is in couch_httpd.erl).
---
If your project is set up for it, you can reply to this email and have
Github user jaydoane commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
Yes, I seem to have tested that code snippet on a non-mochiweb socket
(without the tuple), which is utterly my bad :(
---
If your project is set up for it, you can reply to this email and
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
/:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/COUCHDB-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366301#comment-15366301
]
ASF subversion and git services commented on COUCHDB-3049:
--
Commit
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
So technically the fix of existed code should be:
```
sockname({ssl, Socket}) ->
ssl:sockname(Socket).
```
?
---
If your project is set up for it, you can reply to
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/130
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/128
@rnewson Well, this PR applies changes for the case when Host header is not
present. What kind of function_clause happens and where?
---
If your project is set up for it, you can reply to
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/128
This causes a function_clause whenever a Host header is not present (i.e,
whenever this code is invoked).
---
If your project is set up for it, you can reply to this email and have your
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/741#discussion_r69899075
--- Diff: app/addons/documents/doc-editor/components.react.jsx ---
@@ -218,44 +218,137 @@ var AttachmentsPanelButton = React.createClass({
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/741#discussion_r69898965
--- Diff: app/addons/documents/doc-editor/components.react.jsx ---
@@ -218,44 +218,137 @@ var AttachmentsPanelButton = React.createClass({
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/741#discussion_r69898529
--- Diff: app/addons/documents/doc-editor/components.react.jsx ---
@@ -218,44 +218,137 @@ var AttachmentsPanelButton = React.createClass({
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/741#discussion_r69898286
--- Diff: app/addons/documents/doc-editor/components.react.jsx ---
@@ -218,44 +218,137 @@ var AttachmentsPanelButton = React.createClass({
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/741#discussion_r69896784
--- Diff: app/addons/documents/doc-editor/components.react.jsx ---
@@ -218,44 +218,137 @@ var AttachmentsPanelButton = React.createClass({
20 matches
Mail list logo
