Github user tonysun83 commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/56
@rnewson: thx for pointing that out. I think my new change should adhere to
the behavior we want:
1) If there is no config or if it's a non positive integer, then we just
use
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/56
hrm, this still isn't quite right.
current behaviour, limit defaults to `16#1000` (268,435,456 in
decimal), but a user could specify a higher value and it would work
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77550375
--- Diff: include/couch_mrview.hrl ---
@@ -10,6 +10,8 @@
% License for the specific language governing permissions and limitations
under
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77550364
--- Diff: include/couch_mrview.hrl ---
@@ -10,6 +10,8 @@
% License for the specific language governing permissions and limitations
under
[
https://issues.apache.org/jira/browse/COUCHDB-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Will Holley resolved COUCHDB-3017.
--
Resolution: Fixed
Fix Version/s: 2.0.0
Verified fixed in master
> CouchDB 2.0:
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/56
If it still planned to be accepted, for the lesser surprise there should be:
1) The way to return good old behaviour back.
2) The warning in the logs that by default we do limit
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/56
Good points, @rnewson. Changing my to -1. I think this need for more wide
discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tonysun83 commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/56
updated with macros and created corresponding jira ticket
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Tony Sun created COUCHDB-3130:
-
Summary: make query limits configurable
Key: COUCHDB-3130
URL: https://issues.apache.org/jira/browse/COUCHDB-3130
Project: CouchDB
Issue Type: Improvement
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/56
hrm, very bleh. Ok, please make that a `-define` and update in both places;
we'll have to come back to this. A default finite limit for _all_docs seems
like a contract-breaking detail
Github user tonysun83 commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/56
@rnewson: I'm using the original value here:
https://github.com/cloudant/couchdb-couch-mrview/blob/92575f448bbba34466e64ab595aa3ec8af3c96b6/include/couch_mrview.hrl#L76.
Isn't that
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/768
License headers & remove of unused dep
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton license
Github user robertkowalski commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/767
+1 after adding a license header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/767
My output when I run it
```
> fauxton@1.1.8 webpack:depcheck /Users/garren/dev/couchdb-fauxton
> node ./bin/depCheck.js
âââ react-select@1.0.0-beta14
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/767
Check dependencies added to Fauxton build
run `npm run webpack:depcheck` to list all dependencies
You can merge this pull request into a Git repository by running:
$ git pull
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/56
and there's no JIRA ticket associated with this change either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
16 matches
Mail list logo