[GitHub] couchdb-couch-mrview pull request #72: Fix end-point _local_docs

Github user eiri commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107330320 --- Diff: src/couch_mrview.erl --- @@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) -> end. +get_total_rows(#db{local_

[GitHub] couchdb-couch-mrview pull request #72: Fix end-point _local_docs

Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107329994 --- Diff: src/couch_mrview.erl --- @@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) -> end. +get_total_rows(#db{loca

[GitHub] couchdb-couch-mrview issue #72: Fix end-point _local_docs

Github user jaydoane commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/72 This LGTM, and tests pass for me locally: ``` module 'couch_mrview_local_docs_tests' _local_docs view tests couch_mrview_local_docs_tests:68: should_query...ok

[GitHub] couchdb-couch-mrview pull request #72: Fix end-point _local_docs

Github user eiri commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107325855 --- Diff: test/couch_mrview_local_docs_tests.erl --- @@ -0,0 +1,134 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you ma

[GitHub] couchdb-couch-mrview pull request #72: Fix end-point _local_docs

Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107325722 --- Diff: test/couch_mrview_local_docs_tests.erl --- @@ -0,0 +1,134 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); yo

[GitHub] couchdb-couch-mrview pull request #72: Fix end-point _local_docs

Github user eiri commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107318756 --- Diff: src/couch_mrview.erl --- @@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) -> end. +get_total_rows(#db{local_

[GitHub] couchdb-couch-mrview pull request #72: Fix end-point _local_docs

Github user sagelywizard commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107306442 --- Diff: src/couch_mrview.erl --- @@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) -> end. +get_total_rows(#d

[GitHub] couchdb-couch-mrview issue #72: Fix end-point _local_docs

Github user eiri commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/72 @davisp @iilyak Can you take a look, please, whenever you'll have time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[jira] [Commented] (COUCHDB-3337) End-point _local_docs doesn't conform to query params of _all_docs

[ https://issues.apache.org/jira/browse/COUCHDB-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935485#comment-15935485 ] ASF GitHub Bot commented on COUCHDB-3337: - GitHub user eiri opened a pull reques

[GitHub] couchdb-couch-mrview pull request #72: Fix end-point _local_docs

GitHub user eiri opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/72 Fix end-point _local_docs This fixes the following issues with `/{db}/_local_docs` end-point: 1. Query ignores `include_docs` parameter 1. Query reports incorrect `total_rows`

[jira] [Created] (COUCHDB-3337) End-point _local_docs doesn't conform to query params of _all_docs

Eric Avdey created COUCHDB-3337: --- Summary: End-point _local_docs doesn't conform to query params of _all_docs Key: COUCHDB-3337 URL: https://issues.apache.org/jira/browse/COUCHDB-3337 Project: CouchDB