[GitHub] jaydoane commented on a change in pull request #1176: Implement pluggable authentication and session support for replicator

2018-02-21 Thread GitBox
jaydoane commented on a change in pull request #1176: Implement pluggable authentication and session support for replicator URL: https://github.com/apache/couchdb/pull/1176#discussion_r169873527 ## File path: src/couch_replicator/src/couch_replicator_auth.erl ## @@ -0,0 +1

[Jenkins] SUCCESS: CouchDB ยป master #194

2018-02-21 Thread Apache Jenkins Server
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/194/

[GitHub] nickva closed pull request #1177: Avoid unconditional retries in replicator's http client

2018-02-21 Thread GitBox
nickva closed pull request #1177: Avoid unconditional retries in replicator's http client URL: https://github.com/apache/couchdb/pull/1177 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] nickva commented on a change in pull request #1177: Avoid unconditional retries in replicator's http client

2018-02-21 Thread GitBox
nickva commented on a change in pull request #1177: Avoid unconditional retries in replicator's http client URL: https://github.com/apache/couchdb/pull/1177#discussion_r169827307 ## File path: src/couch_replicator/src/couch_replicator_httpc.erl ## @@ -139,12 +139,12 @@ pro

[GitHub] davisp commented on a change in pull request #1177: Avoid unconditional retries in replicator's http client

2018-02-21 Thread GitBox
davisp commented on a change in pull request #1177: Avoid unconditional retries in replicator's http client URL: https://github.com/apache/couchdb/pull/1177#discussion_r169815489 ## File path: src/couch_replicator/src/couch_replicator_httpc.erl ## @@ -139,12 +139,12 @@ pro

[GitHub] nickva opened a new pull request #1177: Avoid unconditional retries in replicator's http client

2018-02-21 Thread GitBox
nickva opened a new pull request #1177: Avoid unconditional retries in replicator's http client URL: https://github.com/apache/couchdb/pull/1177 In some cases the higher level code from `couch_replicator_api_wrap` needs to handle retries explicitly and cannot cope with retries happening

[GitHub] jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum

2018-02-21 Thread GitBox
jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum URL: https://github.com/apache/couchdb/pull/1139#issuecomment-367381444 @rnewson I've done some more testing on the deletion with different cluster conditions. It seems that some .couch files keep

[GitHub] jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum

2018-02-21 Thread GitBox
jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum URL: https://github.com/apache/couchdb/pull/1139#issuecomment-367381444 @rnewson I've done some more testing on the deletion with different cluster conditions. It seems that some .couch files keep

[GitHub] jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum

2018-02-21 Thread GitBox
jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum URL: https://github.com/apache/couchdb/pull/1139#issuecomment-367381444 @rnewson I've done some more testing on the deletion with different cluster conditions. It seems that some .couch files keep

[GitHub] davisp commented on issue #496: Couchdb 3287 pluggable storage engines

2018-02-21 Thread GitBox
davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-367357591 Has anyone got any reason for me to not merge this in 72h or whenever? I've rebased it against master and its passing CI checks. As far as I remember

[GitHub] AlexanderKaraberov commented on issue #1166: Fix: badmatch crash in couch_mrview_util.erl reduced_external_size()

2018-02-21 Thread GitBox
AlexanderKaraberov commented on issue #1166: Fix: badmatch crash in couch_mrview_util.erl reduced_external_size() URL: https://github.com/apache/couchdb/pull/1166#issuecomment-367249927 @eiri Thanks! Yes, indeed, my "fix" was just an ad-hoc solution to the problem I had with my test DB. I'